-
Notifications
You must be signed in to change notification settings - Fork 53
6473 add otel config #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
6473 add otel config #108
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1deefa2
Add env_file to pender service in docker-compose.yml
vasconsaurus 2a31347
Remove depends_on pender from otel-collector
vasconsaurus e8a3e19
Fix pender .env path
vasconsaurus 94857fb
Update otel-collector in docker-compose
vasconsaurus cd54efb
Add OpenTelemetry Collector config
vasconsaurus 283cc8e
Comment env_file
vasconsaurus 241a76f
Add comment
vasconsaurus 443b260
Update README
vasconsaurus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| receivers: | ||
| prometheus: | ||
| config: | ||
| scrape_configs: | ||
| - job_name: "prometheus" | ||
| scrape_interval: 15s | ||
| static_configs: | ||
| - targets: ["pender:3200"] | ||
|
|
||
| processors: | ||
| memory_limiter: | ||
| check_interval: 1s | ||
| limit_percentage: 80 | ||
| spike_limit_percentage: 20 | ||
| batch: | ||
| timeout: 200ms | ||
| send_batch_size: 8192 | ||
|
|
||
| exporters: | ||
| otlp/metrics: | ||
| endpoint: "api.honeycomb.io:443" # US instance | ||
| #endpoint: "api.eu1.honeycomb.io:443" # EU instance | ||
| headers: | ||
| "x-honeycomb-team": ${env:x_honeycomb_team} # Honeycomb API KEY | ||
| "x-honeycomb-dataset": "pender" | ||
|
|
||
| service: | ||
| # telemetry: | ||
| # logs: | ||
| # level: "debug" | ||
| pipelines: | ||
| metrics: | ||
| receivers: [prometheus] | ||
| processors: [memory_limiter, batch] | ||
| exporters: [otlp/metrics] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the commented lines in this file here because we don’t need them anymore (in which case, why not just delete them?), or because we’re supposed to uncomment them to enable something?
If it’s the latter, could you please add comments to clarify this (or add instructions to the README)?
For example: “Uncomment the X lines below to enable OTEL.”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we first added the
otel-collectorwe opted to keep it commented out, because we won't be running by default locally. I'll add a comment, and see if it makes sense to add something to the README.