websockets: use native websockets and remove extra dependencies #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since runtime version 22.4.0, W3C WebSockets Client API is available on node. We can switch to the native implementation, getting rid of two dependencies and some code that becomes useless. There are a couple of downsides, though: - Increase minimum runtime version to 22.4.0 (released on July 2024) - Make impossible to send unsolicited ping frames from Janode (since this API is not exposed by the W3C specs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since runtime version 22.4.0, W3C WebSockets Client API is available on node.
We can switch to the native implementation, getting rid of two dependencies and some code that becomes useless.
There are a couple of downsides, though:
This will need a minor version bump (e.g. 1.8.x).