Use root relative link and directory-style URL for plain text nodes #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @melissawm, this is a pretty small change that I think can be merged as-is. Would you mind merging when you get the chance? |
story645
approved these changes
Sep 5, 2025
story645
reviewed
Sep 5, 2025
src/sphinx_tags/__init__.py
Outdated
| return [result] | ||
|
|
||
| def _get_plaintext_node( | ||
| self, tag: str, file_basename: str, relative_tag_dir: Path |
There was a problem hiding this comment.
relative_tag_dir is now unused, right?
There was a problem hiding this comment.
Ah yes thanks for catching that. Let me update this.
Done! Thank you.
There was a problem hiding this comment.
@story645 , would you be able to merge the PR?
Thanks.
- Use root relative link instead of directory-relative URL which caused tags to be appended to the on-page tags for plaintext nodes. - Use directory-style URLs instead of appending .html to match the implementation for badges.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issue where links are not rendered correctly for plaintext nodes:
Link to the parent tags page should be "/_tags/how-to/" but it is currently generated wrongly as "/how-to/_tags/how-to/" due to the relative path.
Hope this is enough info; lemme know if anything else is needed, thank you!