-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Apply post_process
automatically to all stream types
#3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis pull request refactors record post-processing by centralizing the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
+ Coverage 91.64% 91.71% +0.06%
==========================================
Files 62 62
Lines 5315 5311 -4
Branches 686 684 -2
==========================================
Hits 4871 4871
+ Misses 312 310 -2
+ Partials 132 130 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #3023 will not alter performanceComparing Summary
|
@sourcery-ai review |
post_process
automatically to all stream typespost_process
automatically to all stream types
@sourcery-ai review |
@sourcery-ai review |
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes - here's some feedback:
- Consider if adding
updatedAt
toSimpleTestStream
records inconftest.py
affects unrelated tests expecting the previous record structure. - For streams inheriting directly from
Stream
(rather thanSQLStream
orRESTStream
),post_process
is now called by the framework; verify this doesn't conflict with any manualpost_process
calls in customget_records
implementations.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
With this change, developers won't need to re-implement the call to
post_process
when they override the publicStream.get_records(...)
method.A few examples just from MeltanoLabs: https://github.com/search?q=org%3AMeltanoLabs+%22self.post_process%22&type=code.
i.e.
Summary by Sourcery
Automatically apply
post_process
method to all stream types during record synchronizationNew Features:
post_process
method for all stream types during record syncEnhancements:
Tests: