Fix MCP search_memory NoneType iteration error

[frederikb96]

Problem

MCP search_memory endpoint crashed with TypeError: argument of type 'NoneType' is not iterable when filtering search results by ACL permissions.

Root cause: Boolean logic error in filter condition (line 187):

if allowed and h.id is None or h.id not in allowed:  # Wrong

This evaluates as (allowed and h.id is None) or (h.id not in allowed), causing crash when allowed is a non-empty set.

Fix

Corrected the boolean logic:

if allowed is not None and h.id not in allowed:  # Correct

Now properly checks: "If ACL filter exists AND memory ID not in allowed set, skip it"

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Test Script - MCP search now returns results without TypeError
• Verified with populated memory database and ACL filtering

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes generate no new warnings

[parshvadaftari]

Looks good to me.

[parshvadaftari]

Good catch @frederikb96 thanks for pointing it out and fixing it.

[frederikb96]

@parshvadaftari Thank you very much for starting to merge some of my PRs 🙂

Any chance that my other PRs are getting merged soon? 🙂

They are all mostly tiny atomic changes all around the OpenMemory sub project. There were many bugs and problems in it and a lot of room for improvements. Since I am using it on my fork now in production, I refactored all and created all those atomic PRs. I have like 10 more to go - some bigger once, too 😄 but they depend on those here. So I wait for the subsequent PRs until you decided if merging is fine or changes are needed, etc. 🙂

#3624
#3620
#3619
#3618
#3616
#3607
#3601

[parshvadaftari]

Hey @frederikb96 thank you for the prs, our team is reviewing them. Thank for fixing the bugs, will drop comments on them 😄

[parshvadaftari]

Looks good to me!

[frederikb96]

@parshvadaftari I rebased again on main, ready to merge? 🙂