(feat/extract) Move extract to a queue system #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: apps/api/src/lib/extract/extraction-service.ts
📄 File: apps/api/src/services/queue-worker.ts (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
|
This uses a different queue but we can merge it to be on 1 queue only if preferred @mogery |
nickscamara
changed the title
nickscamara
changed the title
|
mogery
approved these changes
Jan 7, 2025
Comment on lines
14
to
18
| const rateLimiter = scrapeStatusRateLimiter; | ||
| const incomingIP = (req.headers["x-forwarded-for"] || | ||
| req.socket.remoteAddress) as string; | ||
| const iptoken = incomingIP; | ||
| await rateLimiter.consume(iptoken); |
There was a problem hiding this comment.
Why is this here? This is handled by the authMiddleware.
| req: RequestWithAuth<{ jobId: string }, any, any>, | ||
| res: Response, | ||
| ) { | ||
| try { |
There was a problem hiding this comment.
You must not wrap v1 endpoint controllers in a try-catch. Error handling is done on the Express middleware level.
Comment on lines
20
to
34
| const job = await supabaseGetJobByIdOnlyData(req.params.jobId); | ||
| if (!job || job.team_id !== req.auth.team_id) { | ||
| return res.status(403).json({ | ||
| success: false, | ||
| error: "You are not allowed to access this resource.", | ||
| }); | ||
| } | ||
|
|
||
| const jobData = await supabaseGetJobsById([req.params.jobId]); | ||
| if (!jobData || jobData.length === 0) { | ||
| return res.status(404).json({ | ||
| success: false, | ||
| error: "Job not found", | ||
| }); | ||
| } |
|
Wrong branch, will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.