Skip to content

Conversation

@MarkvanMents
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First shot at adding a domain model and doing a quick review.

Copy link
Contributor

@pijuskri pijuskri Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Customer entity is mostly defined with LastName/FirstName in the examples. Only a few examples on Line 789 breaks that an includes Age and TotalOrderAmount. Perhaps let's rename the entity there to something else like CustomerInfo and use it in the COALESCE examples

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this in bbefcea

@MarkvanMents
Copy link
Collaborator Author

@pijuskri
Hi Pijus, I've finally found time to respond to your review. Sorry about the delay.
Let me know if you have any further comments, or whether I can merge this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants