Skip to content

[MOO-1995] video player stops during silent mode #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MOO-1995] video player stops during silent mode #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/pluggableWidgets/video-player-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

- Set `ignoreSilentSwitch` to `ignore` to allow audio playback even when device is in silent mode on iOS

### Changed

- We have removed react-native-system-navigation-bar and deprecated-react-native-prop-types dependencies. Navigation bar visibility is now handled by the react-native-video package.
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/video-player-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "video-player-native",
"widgetName": "VideoPlayer",
"version": "6.3.0",
"version": "6.3.1",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
1 change: 1 addition & 0 deletions packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
import { isAvailable } from "@mendix/piw-utils-internal";
import deepmerge from "deepmerge";

const enum StatusEnum {

Check warning on line 22 in packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

'StatusEnum' is defined but never used. Allowed unused vars must match /createElement/u
ERROR = "error",

Check warning on line 23 in packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

'ERROR' is defined but never used. Allowed unused vars must match /createElement/u
LOADING = "loading",

Check warning on line 24 in packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

'LOADING' is defined but never used. Allowed unused vars must match /createElement/u
READY = "ready",

Check warning on line 25 in packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

'READY' is defined but never used. Allowed unused vars must match /createElement/u
NOT_READY = "not-ready"

Check warning on line 26 in packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

'NOT_READY' is defined but never used. Allowed unused vars must match /createElement/u
}

export function VideoPlayer(props: VideoPlayerProps<VideoStyle>): ReactElement {
Expand Down Expand Up @@ -52,7 +52,7 @@
}
}
setStyles(alteredStyles);
}, [props.style, props.aspectRatio, videoAspectRatio]);

Check warning on line 55 in packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

React Hook useEffect has a missing dependency: 'styles'. Either include it or remove the dependency array

const showControlsHandler = useCallback((): void => {
clearTimeout(timeoutRef.current as NodeJS.Timeout);
Expand Down Expand Up @@ -102,6 +102,7 @@
muted: props.muted,
repeat: props.loop,
controls: props.showControls,
ignoreSilentSwitch: "ignore",
onLoadStart: () => setStatus(StatusEnum.LOADING),
onError: () => setStatus(StatusEnum.ERROR),
useTextureView: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/video-player-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="VideoPlayer" version="6.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="VideoPlayer" version="6.3.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="VideoPlayer.xml" />
</widgetFiles>
Expand Down
Loading