[WC-3198]: Custom chart: static/source data merge #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
changed the title
rahmanunver
changed the title
rahmanunver
force-pushed
the
wc-3198_customchart_data_merge
branch
from
132106c to
dca6aef
Compare
iobuhov
reviewed
Dec 18, 2025
| for (let i = 0; i < maxLen; i++) { | ||
| const staticTrace = (staticTraces[i] ?? {}) as Record<string, unknown>; | ||
| const dynamicTrace = (dynamicTraces[i] ?? {}) as Record<string, unknown>; | ||
| result.push(deepmerge(staticTrace, dynamicTrace, mergeOptions) as Data); |
Collaborator
There was a problem hiding this comment.
Instead of always passing mergeOptions can we create create our own function?
const deepmergePlotly = (a,b) => deepmerge(a, b, { arrayMerge: (_, source) => source })?
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Fixed |
rahmanunver
force-pushed
the
wc-3198_customchart_data_merge
branch
from
5b398b5 to
e251a40
Compare
rahmanunver
force-pushed
the
wc-3198_customchart_data_merge
branch
from
e251a40 to
9b3fb3e
Compare
samuelreichert
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Custom chart doesn't merge Static data and Source attribute data properly.
What should be covered while testing?