Skip to content

fix(extension): resync detected language on tab visibility #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frogGuaGuaGuaGua wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(extension): resync detected language on tab visibility #1282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/entrypoints/host.content/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { ContentScriptContext } from "#imports"
import type { LangCodeISO6393 } from "@read-frog/definitions"
import type { Config } from "@/types/config/config"
import { storage } from "#imports"
import { DEFAULT_CONFIG, DETECTED_CODE_STORAGE_KEY } from "@/utils/constants/config"
import { DEFAULT_CONFIG, DEFAULT_DETECTED_CODE, DETECTED_CODE_STORAGE_KEY } from "@/utils/constants/config"
import { getDocumentInfo } from "@/utils/content/analyze"
import { ensurePresetStyles } from "@/utils/host/translate/ui/style-injector"
import { logger } from "@/utils/logger"
Expand Down Expand Up @@ -34,6 +34,27 @@ export async function bootstrapHostContent(ctx: ContentScriptContext, initialCon

const cleanupTranslationShortcut = await bindTranslationShortcutKey(manager)

let latestDetectedCode: LangCodeISO6393 = DEFAULT_DETECTED_CODE

const syncDetectedCodeToStorage = async (detectedCode: LangCodeISO6393) => {
latestDetectedCode = detectedCode

if (document.visibilityState !== "visible") {
return
}

await storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, detectedCode)
}

const handleDocumentVisibilityChange = () => {
if (window !== window.top || document.visibilityState !== "visible") {
return
}

void storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, latestDetectedCode)
}
document.addEventListener("visibilitychange", handleDocumentVisibilityChange)

// For late-loading iframes: check if translation is already enabled for this tab
let translationEnabled = false
try {
Expand All @@ -57,7 +78,7 @@ export async function bootstrapHostContent(ctx: ContentScriptContext, initialCon
if (window === window.top) {
const { detectedCodeOrUnd } = await getDocumentInfo()
const detectedCode: LangCodeISO6393 = detectedCodeOrUnd === "und" ? "eng" : detectedCodeOrUnd
await storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, detectedCode)
await syncDetectedCodeToStorage(detectedCode)
// Notify background script that URL has changed, let it decide whether to automatically enable translation
void sendMessage("checkAndAskAutoPageTranslation", { url: to, detectedCodeOrUnd })
}
Expand Down Expand Up @@ -85,6 +106,7 @@ export async function bootstrapHostContent(ctx: ContentScriptContext, initialCon
cleanupPageTranslationTriggers()
cleanupTranslationShortcut()
cleanupTranslationStateListener()
document.removeEventListener("visibilitychange", handleDocumentVisibilityChange)
window.removeEventListener("extension:URLChange", handleExtensionUrlChange)
window.__READ_FROG_HOST_INJECTED__ = false
clearEffectiveSiteControlUrl()
Expand All @@ -94,7 +116,7 @@ export async function bootstrapHostContent(ctx: ContentScriptContext, initialCon
if (window === window.top) {
const { detectedCodeOrUnd } = await getDocumentInfo()
const initialDetectedCode: LangCodeISO6393 = detectedCodeOrUnd === "und" ? "eng" : detectedCodeOrUnd
await storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, initialDetectedCode)
await syncDetectedCodeToStorage(initialDetectedCode)

// Check if auto-translation should be enabled for initial page load
void sendMessage("checkAndAskAutoPageTranslation", { url: window.location.href, detectedCodeOrUnd })
Expand Down