Skip to content

fix: "GPU Acceleration" section missing after enabling Experimental Mode since version 0.5.15 #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025

Conversation

emeric-martineau
Copy link

Describe Your Changes

Since version 0.5.15, the section GPU Acceleration in Advanced setting was remove when Experimental Mode is enable but documentation was not updated.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@david-menloai
Copy link
Contributor

hi @emeric-martineau
thanks a lot for your contribution, I've left a couple of comments, could you please help take a look 🙏

@emeric-martineau emeric-martineau force-pushed the dev branch 2 times, most recently from 10b7be9 to fb1ee03 Compare March 31, 2025 11:51
@emeric-martineau
Copy link
Author

Hi @david-menloai

Update done. Thank for for your review.

@david-menloai
Copy link
Contributor

hi @emeric-martineau can you pelase help resolve the conflict?
it should be good to merge after this :)

@emeric-martineau
Copy link
Author

emeric-martineau commented Apr 7, 2025

Hello @david-menloai ,
done

Copy link
Contributor

@david-menloai david-menloai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-menloai
Copy link
Contributor

david-menloai commented Apr 11, 2025

hi @emeric-martineau
sorry for bother you again
it looks like there is a missing closing </Tabs> tag in this file /docs/src/pages/docs/desktop/windows.mdx
can you please help double check it?

@emeric-martineau
Copy link
Author

Hello @david-menloai,

sorry for this error 😕. I have fixed it and double check modifications.

I hope this time is good 🤞

Copy link
Contributor

@david-menloai david-menloai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-menloai david-menloai merged commit 535f2b4 into menloresearch:dev Apr 13, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: "GPU Acceleration" section removed in v0.5.15 but the documentation is not updated
2 participants