Skip to content

feat: bounty issue 34 - #119

Open
CloneBro wants to merge 1 commit into
mergeos-bounties:masterfrom
CloneBro:fix/issue-34-1784716664
Open

feat: bounty issue 34#119
CloneBro wants to merge 1 commit into
mergeos-bounties:masterfrom
CloneBro:fix/issue-34-1784716664

Conversation

@CloneBro

Copy link
Copy Markdown
Contributor

Automated PR for issue 34

@laurentketterle-hub

Copy link
Copy Markdown

Hi maintainers (@mergeos-bounties) and @CloneBro — flagging that PR #119 appears to be a boilerplate placeholder rather than an implementation of issue #34 ("optional MediaPipe subject score path"):

  1. No implementation logic. The only test file (tests/test_bounty_sweep.py) is a placeholder — it contains a single def test_environment(): assert True — with no code touching the MediaPipe score path, no mediapipe_path parameter, and no fallback logic.
  2. The addition count is inflated by an auto-generated lockfile. The bulk of the ~1,800 additions is uv.lock (generated), not feature code, so the PR's apparent size does not reflect real work on the issue.
  3. It does not satisfy the issue's acceptance criterion. The issue explicitly asks for fallback tests (offline toy path stays default); this PR has no fallback tests and no MediaPipe integration at all.

For comparison, PR #182 (feat: optional MediaPipe subject scoring path) implements the requested optional path — a mediapipe_path parameter and optional MediaPipe landmark detector integration. Happy to address any feedback from the maintainer.

@laurentketterle-hub

Copy link
Copy Markdown

@CloneBro — thanks for the submission, but this PR does not implement issue #34 and is effectively boilerplate. Three precise reasons:

  1. No feature logic — the only test file (tests/test_bounty_sweep.py) contains a single test_environment() whose body is assert True. That is a no-op placeholder; it exercises none of the MediaPipe subject-score path described in [200 MRG] Feature: optional MediaPipe subject score path #34.

  2. Padding via lockfile — 1,803 of the 1,806 added lines are uv.lock, an auto-generated dependency lockfile. It carries zero implementation and inflates the diff without touching any scoring/vision code.

  3. Acceptance criteria unmet[200 MRG] Feature: optional MediaPipe subject score path #34 requires an optional vision path with the toy path kept as the offline default, plus fallback tests. There is no mediapipe_path option, no landmark-detector integration, and no fallback tests here.

A real implementation is already open at #182 (feat: optional MediaPipe subject scoring path), which adds the optional mediapipe_path parameter and MediaPipe landmark integration while keeping the toy path as the offline default. That is the PR that actually satisfies the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants