You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi maintainers (@mergeos-bounties) and @CloneBro — flagging that PR #119 appears to be a boilerplate placeholder rather than an implementation of issue #34 ("optional MediaPipe subject score path"):
No implementation logic. The only test file (tests/test_bounty_sweep.py) is a placeholder — it contains a single def test_environment(): assert True — with no code touching the MediaPipe score path, no mediapipe_path parameter, and no fallback logic.
The addition count is inflated by an auto-generated lockfile. The bulk of the ~1,800 additions is uv.lock (generated), not feature code, so the PR's apparent size does not reflect real work on the issue.
It does not satisfy the issue's acceptance criterion. The issue explicitly asks for fallback tests (offline toy path stays default); this PR has no fallback tests and no MediaPipe integration at all.
For comparison, PR #182 (feat: optional MediaPipe subject scoring path) implements the requested optional path — a mediapipe_path parameter and optional MediaPipe landmark detector integration. Happy to address any feedback from the maintainer.
@CloneBro — thanks for the submission, but this PR does not implement issue #34 and is effectively boilerplate. Three precise reasons:
No feature logic — the only test file (tests/test_bounty_sweep.py) contains a single test_environment() whose body is assert True. That is a no-op placeholder; it exercises none of the MediaPipe subject-score path described in [200 MRG] Feature: optional MediaPipe subject score path #34.
Padding via lockfile — 1,803 of the 1,806 added lines are uv.lock, an auto-generated dependency lockfile. It carries zero implementation and inflates the diff without touching any scoring/vision code.
Acceptance criteria unmet — [200 MRG] Feature: optional MediaPipe subject score path #34 requires an optional vision path with the toy path kept as the offline default, plus fallback tests. There is no mediapipe_path option, no landmark-detector integration, and no fallback tests here.
A real implementation is already open at #182 (feat: optional MediaPipe subject scoring path), which adds the optional mediapipe_path parameter and MediaPipe landmark integration while keeping the toy path as the offline default. That is the PR that actually satisfies the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR for issue 34