-
Notifications
You must be signed in to change notification settings - Fork 20
Add "Windows 365 Portal" #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @gcl-sekoia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a new entry to the OtherMicrosoftApps.csv
file. Specifically, it adds the "Windows 365 Portal" application with its corresponding ID. This will likely allow the application to be recognized and handled correctly by whatever system uses this data.
Highlights
- New Application Entry: Adds 'Windows 365 Portal' to the list of Microsoft applications in
OtherMicrosoftApps.csv
. - Application ID: Includes the application ID
3b511579-5e00-46e1-a89e-a6f0870e2f5a
for 'Windows 365 Portal'.
Changelog
- customdata/OtherMicrosoftApps.csv
- Added a new row for 'Windows 365 Portal' with the ID '3b511579-5e00-46e1-a89e-a6f0870e2f5a'.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A portal to the cloud,
Windows 365, now allowed.
In the CSV,
A new key,
Access granted, coded proud.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds a new entry to the OtherMicrosoftApps.csv file, which is a community-contributed list of Microsoft apps and their corresponding IDs. This addition seems straightforward and follows the existing format of the file. However, I have a few observations regarding the new entry and the overall structure of the file.
Summary of Findings
- CSV File Structure Consistency: While the new entry follows the basic format, it's important to ensure consistency across all entries. Specifically, the AppOwnerOrganizationId field is empty, which is common but should be reviewed for accuracy. It's also worth considering if there's a standard way to handle the 'Source' field for community-contributed entries.
- Verification of App ID and Display Name: It's crucial to verify that the AppId and AppDisplayName are accurate and correspond to the correct application. This can involve checking the Microsoft Graph API or other reliable sources.
Merge Readiness
The pull request introduces a seemingly straightforward change by adding a new entry to the OtherMicrosoftApps.csv file. However, before merging, it's crucial to verify the accuracy of the AppId and AppDisplayName, as well as consider the consistency of the CSV file structure, particularly the AppOwnerOrganizationId and Source fields. I am unable to directly approve this pull request, and it should be reviewed by others to ensure that the changes are accurate and consistent with the repository's standards. Given the need for verification, I recommend a COMMENT
status.
https://windows365.microsoft.com/ ->
3b511579-5e00-46e1-a89e-a6f0870e2f5a
"Windows 365 Portal"