-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
handle long single-line labels without overflow or cropping #6437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6437 +/- ##
==========================================
- Coverage 3.88% 3.86% -0.02%
==========================================
Files 398 411 +13
Lines 42069 43185 +1116
Branches 638 664 +26
==========================================
+ Hits 1635 1670 +35
- Misses 40434 41515 +1081
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Hi @nourhenta, when reviewing the changes in this PR, it seems that they do not correspond to the title and the information in the PR description. The changes reflect a syntax for reverse edges. |
44380b4
to
38f214f
Compare
Hi @MikeJeffers , thank you for pointing that out. That was a mistake on my part — I accidentally committed unrelated changes. I've corrected it now and the branch reflects the intended fix. Please let me know if anything else needs adjusting! |
Hi! I don’t have permission to approve the Argos build, so if someone from the team could review and approve the visual diffs, that would be great. 😊 Thanks! |
📑 Summary
Fixes a rendering issue where long unbroken labels in flowchart nodes would overflow or get cropped due to static sizing. Nodes now dynamically resize based on the label’s dimensions.
Resolves #6424
📏 Design Decisions
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.