added core package to implement user#79
Open
Ankush523 wants to merge 4 commits intomerokudao:mainfrom
Open
Conversation
r4881t
requested changes
Sep 9, 2023
packages/core/package.json
Outdated
| { | ||
| "name": "core", | ||
| "version": "1.0.0", | ||
| "description": "", |
Contributor
There was a problem hiding this comment.
Add description
"The core components for dApp-SDK. These are required by almost every other package".
packages/core/src/users.ts
Outdated
|
|
||
| abstract createUser(userInput: object | any): void; | ||
| abstract getUser(userInput: object | any): void; | ||
| abstract fetchChats(fetchChatInput: object | any): void; |
Contributor
There was a problem hiding this comment.
These abstract functions are in the messaging class and not needed here. So the messaging-core would extend this "User" and have these functions defined.
Then the specific messaging package can extend on these functions.
r4881t
requested changes
Sep 9, 2023
Contributor
r4881t
left a comment
r4881t
left a comment
There was a problem hiding this comment.
You will also need to bump up the messaging-push and messaging-interface versions
packages/core/package.json
Outdated
| "dist/**/*" | ||
| ], | ||
| "author": "", | ||
| "license": "ISC" |
yarn.lock
Outdated
| linkType: soft | ||
|
|
||
| "@dapp-sdk/core@workspace:packages/core": | ||
| version: 0.0.0-use.local |
Contributor
There was a problem hiding this comment.
What does it do? Can we use simply 1.0.0 as thats the version of the package?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.