forked from Guimove/terraform-aws-bastion
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull from upstream #1
Open
janelletavares
wants to merge
20
commits into
meroxa:master
Choose a base branch
from
Guimove:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating main.tf and adding to locals.tf to resolve ipv6 error\ * reverting the ipv4 blocks back to previous to ensure empty string error isnt masked * added null validator to the ipv4 block as well
* Support instance refresh * Trigger instance refresh on launch template version updates
It was not commited, so let's make it easy to keep it that way.
This is useful if you use Session Manager to connect to your bastion hosts and don't need to load balance across your bastion hosts.
fixes #127 Co-authored-by: Jiří Havelka <[email protected]>
The elb id would be used alongside other resources. For my specific use case, I need a reverse ssh tunnel that needs to connect through the elb and I need to add listeners and target groups
* Add IMDSV2 Support * Add other metadata options
* Fix output issue on bastion_lb for 3.0.3 * Fix for no elb case * docs: Precis that no elb only when no SSH access needed * fix: fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.