[pull] master from RustCrypto:master #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [cpufeatures](https://github.com/RustCrypto/utils) from 0.2.1 to 0.2.2. - [Release notes](https://github.com/RustCrypto/utils/releases) - [Commits](RustCrypto/utils@cpufeatures-v0.2.1...cpufeatures-v0.2.2) --- updated-dependencies: - dependency-name: cpufeatures dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Version 1 of feature resolver always causes features unification of build and dev dependencies, which is unwanted in some circumstances. For example, the `dev` feature of the `digest` always depends on `alloc` which requires to define a global allocator in static libs even though that is never used by library code. Also bumps clippy to v1.60.0.
Releases the following: - `belt-hash` v0.2.0-rc.1 - `blake2` v0.11.0-rc.2 - `md-5` v0.11.0-rc.2 - `ripemd` v0.2.0-rc.1 - `sha1` v0.11.0-rc.2 - `sha2` v0.11.0-rc.2 - `sha3` v0.11.0-rc.2 - `sm3` v0.5.0-rc.1 - `streebog` v0.11.0-rc.2 - `whirlpool` v0.11.0-rc.2
This includes a bump of `keccak` to v0.2.0-rc.0
Releases the following: - `belt-hash` v0.2.0-rc.3 - `blake2` v0.11.0-rc.3 - `md-5` v0.11.0-rc.3 - `ripemd` v0.2.0-rc.3 - `sha1` v0.11.0-rc.3 - `sha2` v0.11.0-rc.3 - `sm3` v0.5.0-rc.3 - `streebog` v0.11.0-rc.3 - `whirlpool` v0.11.0-rc.3
Replaces the logical OR in the G function with addition. It seemingly results in a better ALU utilization and improves performance by several percents. From 699 MB/s to 753 MB/s on my x86 PC and from 910 MB/s to 960 MB/s on Mac M4.
The update_n() implementation propagated carry only through limbs 1..6, effectively making n a 448-bit counter. According to GOST R 34.11-2012 (RFC 6986), the total processed bit-length must be tracked modulo 2^512. This change extends the loop to include limb 7 so carry ripples through all eight 64-bit words and any further carry is discarded, thus restoring correct modulo 2^512 semantics. Although this bug only manifests for astronomically large inputs, it is a correctness issue and brings the implementation in line with the specification and the behavior of similar counters in this codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
48 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )