-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: run tests with pyproject-metadata 0.8.0 #612
CI: run tests with pyproject-metadata 0.8.0 #612
Conversation
fac5b2d
to
ba14bfd
Compare
Once |
I'm debating whether once pyproject-metadata 0.8.0 is released we should keep compatibility with older releases or require 0.8.0 with the next (intended as 0.17.0, not the upcoming 0.16.0) meson-python release and drop the workaround for the bugs fixed in pyproject-metadata (see #613 for what these are). In the past we updated the required minimum version quite aggressively. I don't know if we should be a bit more conservative this time around, given that meson-python is now a build dependency for more packages. |
I think we can still bump fairly aggressively if there's a significant benefit (bug fix we need etc.). We want to be a bit more conservative on average though probably. The main issue occurs for distros that don't have build isolation I think. They tend to unvendor vendored deps, so if we bump the lower bound then we're bumping it for other tools that use
|
I didn't realize either that we don't have an explicit dependency on packaging. I think it is an oversight and not a decision. We definitely should add it. pyproject-metadata requires packaging >= 19.0. AFAIK we don't depend on anything introduced in later versions, so we should add the same constraint. |
Okay, I'll open a separate PR now. |
e678453
to
f170513
Compare
c9e252b
to
fda7dad
Compare
pyproject-metadata 0.8.0 has been released, keep one CI job testing with the oldest supported version to ensure regressions are not introduced.
mypy is always run with the latest version of the dependencies.
fda7dad
to
9ec9229
Compare
No description provided.