Fix hash() and __eq__() for File object #14573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two File objects should compare equal if their combined subdir and fname reference the same path. Currently they don't, so let's fix that. This fixes extract_objects() when called with files() from a different directory than where the original sources were created.
Can you add a testcase (or more likely extend an existing one)? |
bonzini
reviewed
May 8, 2025
| return (self.fname, self.subdir, self.is_built) == (other.fname, other.subdir, other.is_built) | ||
| if self.is_built != other.is_built: | ||
| return False | ||
| spath = os.path.join(self.subdir, self.fname) |
There was a problem hiding this comment.
For performance it's best to cache the result of os.path.join, after all you already compute it at __init__ time.
|
I tried to fix this once and ran into weird corner cases that I don't remember now. JFYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two File objects should compare equal if their combined subdir and fname reference the same path. Currently they don't, so let's fix that.
This fixes extract_objects() when called with files() from a different directory than where the original sources were created.