gnome.mkenums: Fix get_executable_serialisation passing ExternalPrograms script without interpreter #14638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is trivially correct, but since it broke once already we should get a test added for this. |
amyspark
force-pushed
the
fix-regression-glib-mkenums
branch
from
2313c7a to
9d9a8cb
Compare
dcbaker
reviewed
May 30, 2025
nirbheek
reviewed
Jun 2, 2025
amyspark
force-pushed
the
fix-regression-glib-mkenums
branch
from
9d9a8cb to
806dd60
Compare
dcbaker
approved these changes
Jun 2, 2025
|
Please rebase so CI becomes green and we can merge. |
…ams script without interpreter This is an indirect regression of e8c7157; the code never accounted for ExternalPrograms that needed a harness.
…reted executables
amyspark
force-pushed
the
fix-regression-glib-mkenums
branch
from
806dd60 to
2b49818
Compare
|
@nirbheek done, thanks for the headsup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an indirect regression of e8c7157; the code never accounted for ExternalPrograms that needed a harness.
This caused calls to
glib-mkenumsand other scripts that were passed as parameters to only include the direct path to the executable, instead of passing<interpreter> <script path>.