-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Test serialization fixes for macOS, Windows #14649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
169a23d
to
97c9cfa
Compare
Should I add a test? |
Yes, I think having a test would be great. I'm not sure how easy it can be however. |
c37b852
to
137a8a9
Compare
If you add the test first, and then the fix, you could ensure that it isn't working before the fix... |
137a8a9
to
57f2d96
Compare
Question; how should I address https://github.com/mesonbuild/meson/actions/runs/15275533157/job/42960871671?pr=14649#step:5:16? |
You can probably do something like: |
57f2d96
to
bcad352
Compare
Alright, test failure is here: https://github.com/mesonbuild/meson/actions/runs/15276070921/job/42962652326?pr=14649#step:5:320. I'm going to add the fix now :) EDIT: better wait for the entire CI to finish... |
I can easily make the test cross-platform using |
If this is easy, yes, I have no objection. I guess it would test that the LD_LIBRARY_PATH is correctly populated, isn't it? |
b5c9688
to
ceb196d
Compare
Yes 👍 Now I wonder if the test will pass on macOS... EDIT: yeah, it's failing: https://github.com/mesonbuild/meson/actions/runs/15296442821/job/43026602442?pr=14649#step:7:583 |
You can skip the test on Mac by adding
to the build file, and
in test.json |
Thanks :) The test is working an shows an actual issue on macOS, namely that Meson doesn't set |
It's needed on Darwin for the same reason it's needed on generic UNIX. Darwin supports both LD_LIBRARY_PATH and DYLD_LIBRARY_PATH, but the two are not quite equivalent [1], so we set both. [1] https://github.com/ffi/ffi/blob/29ad900a/lib/ffi/dynamic_library.rb#L40
Ok, all lights are green! I'm going to add the final commits now: first the test, then the necessary fixes |
b18c3bc
to
6bfbb00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
Thanks a lot for your help! |
Add directories in PATH for
depends
like we do forargs
Fixes #4668