base64: add 0.5.2 #2441
Open
base64: add 0.5.2 #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
reviewed
Oct 23, 2025
| ) | ||
|
|
||
| cc = meson.get_compiler('c') | ||
| tests_opt = get_option('tests').disable_auto_if(meson.is_subproject()) |
bgilbert
reviewed
Oct 30, 2025
apache-hb
force-pushed
the
base64-5.2.0
branch
2 times, most recently
from
25e41d9 to
921ea29
Compare
bgilbert
reviewed
Nov 2, 2025
apache-hb
force-pushed
the
base64-5.2.0
branch
from
921ea29 to
fdf4b51
Compare
apache-hb
force-pushed
the
base64-5.2.0
branch
from
fdf4b51 to
7e0f523
Compare
bgilbert
reviewed
Nov 18, 2025
| foreach feature, flags : arch_flags | ||
| present = is_x86 and cc.has_multi_arguments(flags) | ||
| config.set10('BASE64_WITH_' + feature, present) | ||
| present_flags += { |
Collaborator
There was a problem hiding this comment.
You could simplify by removing present_flags entirely and doing arch_flags[feature] = [] if not present.
Comment on lines
+47
to
+49
| config.set10('BASE64_WITH_SSSE3', is_x86) | ||
| config.set10('BASE64_WITH_SSE41', is_x86) | ||
| config.set10('BASE64_WITH_SSE42', is_x86) |
Collaborator
There was a problem hiding this comment.
cc.has_multi_arguments([]) evaluates to true, so these are redundant.
| c_args += ['-DBASE64_STATIC_DEFINE'] | ||
| endif | ||
|
|
||
| neon32_supported = host_machine.cpu_family() == 'arm' and cc.has_argument( |
Collaborator
There was a problem hiding this comment.
Couldn't arm and aarch64 use the arch_flags mechanism? I think the is_x86 check isn't actually necessary because the compiler should just fail to support the options that aren't relevant for this CPU.
| ] | ||
| }, | ||
| "aklomp-base64": { | ||
| "_comment": "The test program has a bug that causes it to fail with a SIGILL on x86 platforms without avx512 (all CI runners)", |
Collaborator
There was a problem hiding this comment.
Has this been reported upstream? At minimum we should link to the issue report so it's possible to follow up. Is there any way to work around the bug from meson.build without patching the source?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds version 0.5.2 of aklomps base64 library