Skip to content

Target .net 4.5 and enable tls 1.2 connections #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markvantilburg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Target .net 4.5 and enable tls 1.2 connections #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192501a
Update MessageBird.csproj
markvantilburg Oct 29, 2019
7e8be04
Update RestClient.cs
markvantilburg Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MessageBird/MessageBird.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net40;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net45;net40;netstandard2.0</TargetFrameworks>
<Product>MessageBird</Product>
<Title>MessageBird</Title>
<Company>MessageBird</Company>
Expand All @@ -19,4 +19,4 @@
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
</ItemGroup>
</Project>
</Project>
3 changes: 3 additions & 0 deletions MessageBird/Net/RestClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,9 @@ private HttpWebRequest PrepareRequest(string method, string requestUriString, st
// TODO: ##jwp; need to find out why .NET 4.0 under VS2013 refuses to recognize `WebRequest.CreateHttp`.
// HttpWebRequest request = WebRequest.CreateHttp(uri);
var request = WebRequest.Create(uri) as HttpWebRequest;
#if NET45
ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12 | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls;
#endif
request.UserAgent = UserAgent;
const string ApplicationJsonContentType = "application/json"; // http://tools.ietf.org/html/rfc4627
request.Accept = ApplicationJsonContentType;
Expand Down