(2/n) Add name to channels #1624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add optional string labels to both `ChannelAddr` and `ChannelTransport` enum types to enable user-friendly identification and debugging of channels. ### Changes to ChannelAddr Converted all `ChannelAddr` variants from tuple-style to struct-style with named fields and added an optional `label: Option<String>` field to each variant (local, sim, meta_tls). Added helper methods: * `any_with_label(transport, label: String) -> Self` - Sets a label on an existing address * `label() -> Option<&str>` - Returns the label if present Updated `Display` implementation to show labels in brackets when present: * Without label: `tcp:127.0.0.1:8080` * With label: `tcp:127.0.0.1:8080[my-service]` Follow up is to tag channel usage TODO: Assign values to labels Reviewed By: thedavekwon Differential Revision: D84656187
Summary: Adds label names to Channel instantiation Reviewed By: thedavekwon Differential Revision: D85076897
meta-cla
bot
added
the
CLA Signed
|
@pablorfb-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85076897. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds label names to Channel instantiation
Reviewed By: thedavekwon
Differential Revision: D85076897