Add labels to links #1647
Open
Add labels to links #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changes the signature of `ChannelAddr::serve` and `ChannelAddr::dial` to include a label. Label is marked as a required argument, hence the changes in so many files, but main change is in `net.rs` and `channel.rs` Logs sample: ``` [1] listen host-frontend-unix:CIP0z4kzu05gPBSlpQ2dxh3D: new connection from unix:(unnamed) [0] listen bootstrap-spawn-unix:AE7MIE3IMaJGgpOIFkpFGcdw: new connection from unix:(unnamed) [0] stopping server: [bootstrap-spawn]unix:AE7MIE3IMaJGgpOIFkpFGcdw; reason: NetRx dropped; channel address: unix:AE7MIE3IMaJGgpOIFkpFGcdw [0] serve unix:AE7MIE3IMaJGgpOIFkpFGcdw-bootstrap-spawn: received parent token cancellation [0]: session unix:AE7MIE3IMaJGgpOIFkpFGcdw[bootstrap-spawn].12230889822276986604<-unix:(unnamed): NetRx::process exited its loop with states: initial Next was (seq: 0, ack: 0); final Next is (seq: 1, ack: 0); since acked: 0sec; rcv raw frame count is 1; final result: Ok(()) [0]: session [proc-callback]unix:AE7MIE3IMaJGgpOIFkpFGcdw.12230889822276986604: NetTx exited its loop with state: Running(deliveries: (outbox: (next_seq: 1, deque: []), unacked: (deque: [], largest_acked: (seq=0, since_acked=0sec))), reason: NetTx is dropped) ``` Differential Revision: D85192987
|
@pablorfb-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85192987. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes the signature of
ChannelAddr::serveandChannelAddr::dialto include a label.Label is marked as a required argument, hence the changes in so many files, but main change is in
net.rsandchannel.rsLogs sample:
Differential Revision: D85192987