Expand workspace to cover all crates and enable rust testing #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85676520. |
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 28, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
8902e0c to
34812b8
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 28, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
2 times, most recently
from
1acacdb to
db8c46d
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 29, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 29, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
db8c46d to
15739b3
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 29, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
2 times, most recently
from
4b345ef to
8fb7827
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 29, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 29, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
2 times, most recently
from
82b59f5 to
6eec8ea
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 29, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 29, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
6eec8ea to
a33f202
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 30, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
2 times, most recently
from
5212841 to
066212f
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 30, 2025
…torch#1684) Summary: Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
066212f to
2888186
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 30, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 30, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
2888186 to
22c3229
Compare
dulinriley
force-pushed
the
export-D85676520
branch
from
f01899f to
92aeaf3
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 31, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
92aeaf3 to
43f6334
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 31, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 31, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
43f6334 to
3ac4b8f
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 31, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
3ac4b8f to
acbfcbc
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 31, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
acbfcbc to
546ab1d
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 31, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
546ab1d to
3104a6f
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 3, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
3104a6f to
94a665b
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 3, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
94a665b to
9eba8f5
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 3, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
2 times, most recently
from
bea7a34 to
e7d9413
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 4, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 4, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
e7d9413 to
3d87315
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 4, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
3d87315 to
7be623c
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 4, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
7be623c to
4317038
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 4, 2025
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
4317038 to
3065ab7
Compare
…torch#1684) Summary: Pull Request resolved: meta-pytorch#1684 Expand Github rust testing to the whole workspace of crates in monarch. Tests that do not pass in Github are marked as fb-only for now. Many of them can be fixed easily, but we can turn on the majority of tests right away. Reviewed By: colin2328 Differential Revision: D85676520
dulinriley
force-pushed
the
export-D85676520
branch
from
3065ab7 to
a11f8b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Expand Github rust testing to the whole workspace of crates in monarch.
Tests that do not pass in Github are marked as fb-only for now. Many of them can
be fixed easily, but we can turn on the majority of tests right away.
Differential Revision: D85676520