Stop the SetupActor after running its endpoint #1693
+80
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The SetupActor runs a single function and then does nothing. There's no need to keep the actor loop running and listening for messages. Furthermore, if the setup function was holding onto resources somehow, this will let them get cleaned up. The motivation for this change is that, if the setup function happens to spawn ActorMeshes, there's no way to access them, so we should try to delete them. People should not rely on SetupActor staying around. If they want that, they can spawn their own Actor on the proc mesh that can hold onto process-wide state. Also, SetupActor was an async endpoint calling a synchronous function which made it easy to accidentally block on a PythonTask. Add support for sync and async callback functions. Differential Revision: D85721318
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85721318. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The SetupActor runs a single function and then does nothing. There's no need to keep
the actor loop running and listening for messages.
Furthermore, if the setup function was holding onto resources somehow, this will let them
get cleaned up.
The motivation for this change is that, if the setup function happens to spawn ActorMeshes,
there's no way to access them, so we should try to delete them.
People should not rely on SetupActor staying around. If they want that, they can spawn their
own Actor on the proc mesh that can hold onto process-wide state.
Also, SetupActor was an async endpoint calling a synchronous function which made it easy
to accidentally block on a PythonTask. Add support for sync and async callback functions.
Differential Revision: D85721318