Use std::move to reduce copies in VideoEncoder #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
reviewed
Nov 17, 2025
| VideoStreamOptions videoStreamOptions; | ||
| videoStreamOptions.codec = codec; | ||
| videoStreamOptions.pixelFormat = pixel_format; | ||
| videoStreamOptions.codec = std::move(codec); |
Contributor
There was a problem hiding this comment.
Can you share the lint warning related to that? I'm surprised we need std::move for codec and pixel_format but not for preset?
Made me realize we should make this a string_view like the rest, instead of a string. Same below in the other function.
Contributor
Author
There was a problem hiding this comment.
This comes from clang-tidy:
parameter 'codec' is passed by value and only copied once; consider moving it to avoid unnecessary copies.
Perhaps because preset can be an int, the lint is not raised?
we should make this a string_view like the rest, instead of a string
Thanks for catching this, I'll update this PR
NicolasHug
approved these changes
Nov 18, 2025
src/torchcodec/_core/custom_ops.cpp
Outdated
| #include <cstdint> | ||
| #include <sstream> | ||
| #include <string> | ||
| #include <utility> |
Contributor
There was a problem hiding this comment.
Can you double check whether that's needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves lints and other miscellaneous fixes:
std::moveoncodec,pixel_formatcodectostd::string_viewrather thanstd::stringtryToValidateCodecOption()Noneas default inops.pyextra_optionsto be keyword param invideo_encoder.py