-
Notifications
You must be signed in to change notification settings - Fork 71
Remove tests from collection #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| if get_ffmpeg_major_version() == 4 and format == "wav": | ||
| pytest.skip("Swresample with FFmpeg 4 doesn't work on wav files") | ||
| if IS_WINDOWS and get_ffmpeg_major_version() <= 5 and format == "mp3": | ||
| # TODO: https://github.com/pytorch/torchcodec/issues/837 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to preserve the comment pointing to an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think line 371 is a good place to move this TODO?
scotts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you for fixing this!
Remove skipped tests from collection in internal environment
Prevent internal CI failures from skipped tests by excluding skipped tests from collection in internal environment.
TorchCodec tests were flaky / broken internal because:
pytest.skip()calls, so they were collected but then skipped during executionChanges Made
1. Added
@needs_ffmpeg_climarker to tests that need ffmpeg-clitest_ops.py::TestVideoDecoderOps::test_seek_mode_custom_frame_mappingstest_ops.py::TestVideoDecoderOps:: test_seek_mode_custom_frame_mappings_failstest_encoders.py::TestAudioEncoder::test_against_clitest_encoders.py::TestAudioEncoder::test_video_encoder_against_ffmpeg_clitest_encoders.py::TestAudioEncoder::test_codec_parameter_utilizedtest_encoders.py::TestAudioEncoder::test_codec_spec_vs_impl_equivalencetest_encoders.py::TestAudioEncoder::test_extra_options_utilizedtest_decoders.py::TestVideoDecoder::test_custom_frame_mappings_json_and_bytestest_decoders.py::TestVideoDecoder::test_custom_frame_mappings_init_fails2. Converted runtime skips to collection-time skips
Replaced runtime
pytest.skip()calls withpytest.param(..., marks=pytest.mark.skipif(...))for:3. Updated
conftest.pyto exclude tests internallyModified
pytest_collection_modifyitemshook to exclude tests from collection when running internally if they have:@needs_ffmpeg_climarker@pytest.mark.skip()decorator@pytest.mark.skipif()decorator