fix the fx tracer leaf module logic #3487
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
the algorithm is based on "named_modules()" API from torch.nn.Module, there
could be corner cases that a returned "leaf_module" is not actually called in the
forward pass. for example the umbrella_module would be considered as the top-level
leaf module but it actually won't appear in a fx-traced graph.
example
Differential Revision: D80858379