Enable logging for the plan() function, ShardEstimators and TrainingPipeline class constructors #3521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meta-cla
bot
added
the
CLA Signed
nipung90
added a commit
to nipung90/torchrec
that referenced
this pull request
Nov 6, 2025
…ipeline class constructors (meta-pytorch#3521) Summary: This diff enables the static logging functionality to collect data for: 1) plan() - This will allow us to look at the inputs and outputs to the planner to help with use issue debugging 2) ShardEstimators - This will allow us to look at the inputs and outputs to the ShardEstimators, which gives us the bandwidth inputs to verify if the planner is generating expected values as well as help with debugging OOMs 3) TrainingPipeline - The class type here will be an indicator of which pipeline was used by the training job. The training pipeline has implications on the memory usage and is an important data point to collect to investigate OOMs. Reviewed By: kausv Differential Revision: D86317910
nipung90
force-pushed
the
export-D86317910
branch
from
0f50c2b to
8d4b3e6
Compare
nipung90
added a commit
to nipung90/torchrec
that referenced
this pull request
Nov 6, 2025
…ipeline class constructors (meta-pytorch#3521) Summary: This diff enables the static logging functionality to collect data for: 1) plan() - This will allow us to look at the inputs and outputs to the planner to help with use issue debugging 2) ShardEstimators - This will allow us to look at the inputs and outputs to the ShardEstimators, which gives us the bandwidth inputs to verify if the planner is generating expected values as well as help with debugging OOMs 3) TrainingPipeline - The class type here will be an indicator of which pipeline was used by the training job. The training pipeline has implications on the memory usage and is an important data point to collect to investigate OOMs. Reviewed By: kausv Differential Revision: D86317910
nipung90
force-pushed
the
export-D86317910
branch
from
8d4b3e6 to
b1343d1
Compare
…ipeline class constructors (meta-pytorch#3521) Summary: This diff enables the static logging functionality to collect data for: 1) plan() - This will allow us to look at the inputs and outputs to the planner to help with use issue debugging 2) ShardEstimators - This will allow us to look at the inputs and outputs to the ShardEstimators, which gives us the bandwidth inputs to verify if the planner is generating expected values as well as help with debugging OOMs 3) TrainingPipeline - The class type here will be an indicator of which pipeline was used by the training job. The training pipeline has implications on the memory usage and is an important data point to collect to investigate OOMs. Reviewed By: kausv Differential Revision: D86317910
nipung90
force-pushed
the
export-D86317910
branch
from
b1343d1 to
7bdf208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff enables the static logging functionality to collect data for:
Reviewed By: kausv
Differential Revision: D86317910