Skip to content

Add hash and equality functions to planner types #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add hash and equality functions to planner types #3522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions torchrec/distributed/planner/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,18 @@ class DeviceHardware:
storage: Storage
perf: Perf

def __hash__(self) -> int:
return hash((self.rank, self.storage, self.perf))

def __eq__(self, other: object) -> bool:
if not isinstance(other, DeviceHardware):
return False
return (
self.rank == other.rank
and self.storage == other.storage
and self.perf == other.perf
)


class CustomTopologyData:
"""
Expand Down Expand Up @@ -247,6 +259,17 @@ def get_bw(
else:
return self.inter_host_bw

def __hash__(self) -> int:
return hash((self._inter_host_bw, self._intra_host_bw))

def __eq__(self, other: object) -> bool:
if not isinstance(other, BasicCommsBandwidths):
return False
return (
self._inter_host_bw == other._inter_host_bw
and self._intra_host_bw == other._intra_host_bw
)


class Topology:
"""
Expand Down
Loading