Proposed patch for issue 3353 #3360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Remove author from contributors list
2) Use plural form only if more than one contributors
|
This is how you see the same page as reported in the issue now: 
|
|
Thanks @manwar! It looks like this needs the latest |
|
And Moo looks like this: 
|
Oops, will do it now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3360 +/- ##
==========================================
+ Coverage 73.41% 73.52% +0.10%
==========================================
Files 68 68
Lines 2389 2395 +6
Branches 335 336 +1
==========================================
+ Hits 1754 1761 +7
+ Misses 508 507 -1
Partials 127 127
🚀 New features to boost your workflow:
|
|
Finally Moose look like this: 
|
haarg
requested changes
Jun 1, 2025
| } | ||
| } | ||
| $data->{contributors} = $contributors; | ||
|
|
There was a problem hiding this comment.
This only applies to the release page. The Pod view would still include the extra contributors.
This filtering should probably happen in lib/MetaCPAN/Web/Model/API/Contributors.pm instead.
| @@ -1,7 +1,7 @@ | |||
| <div class="nav-header">Authored by: <a href="/author/[% $release.author %]" class="cpan-author">[% $release.author %]</a></div> | |||
| %% if $contributors.size() { | |||
| <div> | |||
| <button class="contributors-show-button btn-link">and [% $contributors.size() %] contributors</button> | |||
| <button class="contributors-show-button btn-link">and [% $contributors.size() %] [% $contributors.size() > 1 ? 'contributors' : 'contributor' %]</button> | |||
There was a problem hiding this comment.
This can be done with the pluralize function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @oalders,
Please review when you get time.
Issue: #3353
Many Thanks.
Best Regards,
Mohammad