feat: Essential Statements/Expressions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentRPS
added
p: high
This was referenced Nov 16, 2024
Closed
pow/exp will instead be implemented in the corelib as a function for convenience.
implements a way for defining external functions
VincentRPS
changed the title
elenakrittik
requested changes
Nov 16, 2024
crates/metal-mir/src/parcel.rs
Outdated
Comment on lines
35
to
38
| /// All of the defined constants in this module. | ||
| pub constants: Vec<stmt::constant::Constant>, | ||
| /// All of the defined structs in this module. | ||
| pub structs: Vec<super::structure::Struct>, |
There was a problem hiding this comment.
At this point, is there even a reason to keep .statements?
There was a problem hiding this comment.
Honestly, it might be more the other way around. But this data is mostly convenience and searching, only statements is used in codegen the others will be used in optimization and code checks.
elenakrittik
requested changes
Nov 16, 2024
elenakrittik
requested changes
Nov 17, 2024
Co-authored-by: lena <[email protected]>
Co-authored-by: lena <[email protected]>
Co-authored-by: lena <[email protected]>
Co-authored-by: lena <[email protected]>
Co-authored-by: lena <[email protected]>
elenakrittik
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
is_implandimpl_typeproperties for implementing core types)