Skip to content

Conversation

@samuelvanderwaal
Copy link
Contributor

@samuelvanderwaal samuelvanderwaal commented May 19, 2023

Frees up 30k of binary space by removing all the hard-coded error message strings and extracting them to an external file. Clients that want to display the full message can download the file and look up the error message by hexcode.

It's possible this could break people's integration tests if they are relying on specific error messages instead of the message number or type so we need to do some analysis on that.

@samuelvanderwaal samuelvanderwaal requested a review from a team as a code owner May 19, 2023 23:16
@samuelvanderwaal samuelvanderwaal requested review from danenbm and lorisleiva and removed request for a team May 19, 2023 23:16
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5029052145.

@samuelvanderwaal samuelvanderwaal marked this pull request as draft May 19, 2023 23:25
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5029270571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant