Residual training in the downscaling_only mode + add dates to the Item class#174
Merged
LBerth merged 23 commits intometeofrance:mainfrom Nov 3, 2025
Merged
Conversation
Contributor
Metriida
commented
Oct 31, 2025
Metriida
commented
- add dates to the Item class
- store metrics in a list (makes adding new metrics easier)
- the output of the model in downscaling mode is the residual between the coarse grid parameter and the fine grid parameter
added 19 commits
October 29, 2025 17:23
kalharko
approved these changes
Oct 31, 2025
LBerth
approved these changes
Nov 3, 2025
tourniert
reviewed
Nov 3, 2025
Comment on lines
+321
to
+325
| self.list_metrics = [ | ||
| self.acc_metric, | ||
| self.psd_plot_metric, | ||
| self.rmse_psd_plot_metric, | ||
| ] |
Contributor
There was a problem hiding this comment.
Instead of a list, perhaps you could use a MetricCollection? This would simplify the subsequent calls to update() and compute().
See https://lightning.ai/docs/torchmetrics/stable/pages/overview.html#metriccollection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.