fix: broken ci.yml and release.yml workflows#8
Merged
Conversation
- ci.yml: `secrets` isn't a legal context in a job-level `if:` — GitHub Actions rejects the whole run before scheduling any job when it's used there, which is why every push on this repo has failed instantly with zero jobs since this workflow was added. Move the gate to step-level `if: env.GH_TOKEN != ''` (env context is legal there), keeping the same no-op-without-secrets behavior the comment at the top of the file describes. - release.yml: the `darwin-amd64` matrix entry ran on `macos-13`, which is no longer an available runner image — the job queues forever and never starts. This isn't new: v0.1.0's release run had the same job stuck and had to be cancelled, and v0.1.0's published release is still missing the darwin-amd64 binary today. Cross-compile x86_64-apple-darwin from the Apple Silicon macos-14 runner instead (same one already used for the arm64 build).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymlhas failed instantly with zero jobs scheduled on every push since it was added (predates this branch's other changes) — theintegrationjob'sif:referenced thesecretscontext at job level, which GitHub Actions doesn't allow; the whole run gets rejected before any job (even the unrelatedcheckjob) is created. Moved the gate to step-levelif: env.GH_TOKEN != '', preserving the intended "no-op without secrets configured" behavior.release.yml'sdarwin-amd64matrix entry ran onmacos-13, which is no longer an available runner — the job queues forever. Same thing happened on the originalv0.1.0release (job had to be manually cancelled), and v0.1.0's published release is still missing the darwin-amd64 asset today. Now cross-compilesx86_64-apple-darwinfrom the Apple Siliconmacos-14runner (already used for the arm64 build).Test plan