testPyComTest: cleanup imports and provide script for building #2512
Conversation
| msbuild .\PyCOMTest.sln -property:Configuration=Release | ||
| cd x64/Release | ||
| regsvr32 .\PyCOMTest.dll | ||
| run: com/TestSources/PyCOMTest/buildAndRegister.bat /s |
There was a problem hiding this comment.
isn't this likely to work even if the build or regsvr fails?
There was a problem hiding this comment.
This step may pass. But the test would still fail if the registration fails.
I added this param because otherwise the step hangs forever, with the script waiting for confirmation to finish.
| run: com/TestSources/PyCOMTest/buildAndRegister.bat /s | |
| # Pass Silent flag to regsvr32 to avoid hanging on confirmation window | |
| run: com/TestSources/PyCOMTest/buildAndRegister.bat /s |
There was a problem hiding this comment.
I understand the /s, but don't really see the benefit of the new .bat file, especially given it might be misleading when the build or registration fails.
There was a problem hiding this comment.
Just meant as a helper script to build and register the required project for testing. And avoid duplication.
I could add the two lines instruction to com/win32com/test/readme.txt instead.
The helper message when the test finds the server isn't registered (what's assigned to importMsg) should probably direct the user to that readme explicitly.
When we were debugging PyComTests is took me a while to find it even existed.
Follow-up to #2493
Extracted from #2502