Image ingestion improvements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
4 tasks
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
dmsuehir
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
LGTM, the only changes that I would be unsure of are the proxy changes in the test file, because it looks like the tests are run with GHA (for example here), and the docker builds and tests seem to be successful, so it's hard to know if the proxy changes would break anything from GHA runs.
dmsuehir
requested changes
Oct 23, 2024
| exit 1 | ||
| else | ||
| echo "[ $SERVICE_NAME ] Content is as expected." | ||
| fi |
There was a problem hiding this comment.
Sorry, one comment that I have after reviewing Omar's PR - in the test for get_videos (which he's renaming to get_files) it's currently checking RESPONSE_BODY for the video name, but can you add to make it also check for the image name?
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
…hbuehler/GenAIComps into melanie/combined_image_video_ingestion
dmsuehir
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves previous image ingestion implementation by reusing the existing
/generate_captionsendpoint instead of creating a new one, reducing code. I also updated READMEs and tests in both repos. Goes with this PR in GenAIExamples.Issues
RFC
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
No new dependencies
Tests