Add type hints and NumPy-style docstrings to join_flv.py #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n content-length is missing
…or upgrading from a VCS URL to work when the package version is unchanged (pypa/pip#9397, pypa/pip#5780)
- Add module-level docstring describing the FLV joining functionality - Add type hints to all functions, methods, and class attributes - Add NumPy-style docstrings to all public functions and the ECMAObject class - Add FLVTag type alias for FLV tag tuple structure - Import typing annotations (Any, BinaryIO, Callable) - Fix PEP8 issues (blank lines, loop variable naming)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive type hints and NumPy-style docstrings to the
join_flv.pymodule to improve code readability, maintainability, and IDE support.