Skip to content

[DO NOT MERGE] Update language dialog to include MakeCode #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Update language dialog to include MakeCode #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d0fd45b
Update language dialog to include MakeCode
microbit-grace Jun 11, 2025
859e685
Use beta MakeCode temporarily
microbit-grace Jun 11, 2025
5cec9af
Run prettier
microbit-grace Jun 11, 2025
35084ae
Default UI lang to en when lang is not supported
microbit-grace Jun 12, 2025
e840cef
Fix E2E makeCode editor test
microbit-grace Jun 12, 2025
2fff54a
Remove reference to Python Editor in strings
microbit-grace Jun 12, 2025
8140531
Fix previewTranslation flag and reordering tweaks
microbit-grace Jun 12, 2025
071c5ff
Fix language settings
microbit-grace Jun 12, 2025
8326d52
Handle editorVersion query string param
microbit-grace Jun 12, 2025
0b532b3
Revert "Fix E2E makeCode editor test"
microbit-grace Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lang/ui.ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "Idioma",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "Més informació sobre els requisits del tallafoc",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "Language",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
Comment on lines +874 to +889
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the translated strings for these?

"learn-about-firewall-requirements-action": {
"defaultMessage": "Learn about firewall requirements",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.es-es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "Idioma",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "Conoce los requisitos del cortafuegos",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "言語",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "ファイアウォール要件について調べる",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.ko.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "언어 선택",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "방화벽 요구 사항에 대해 알아보기",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.nl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "Taal",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "Meer informatie over firewall vereisten",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.pl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "Język",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "Dowiedz się więcej o wymaganiach firewall",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.pt-br.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "Idioma",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "Saiba mais sobre os requisitos de firewall.",
"description": "Link to support article for firewall requirements"
Expand Down
16 changes: 16 additions & 0 deletions lang/ui.zh-tw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,22 @@
"defaultMessage": "語言",
"description": "Language option text"
},
"language-support-checked": {
"defaultMessage": "Supported",
"description": "Aria label for ticked checkbox for language support"
},
"language-support-unchecked": {
"defaultMessage": "Unsupported",
"description": "Aria label for unticked checkbox for language support"
},
"language-supported-for": {
"defaultMessage": "Translations supported for:",
"description": "Text introducing list of translated areas for a given language (areas: Microsoft MakeCode, micro:bit CreateAI UI itself)"
},
"language-toast-title": {
"defaultMessage": "Language not fully supported",
"description": "Language support toast notification title"
},
"learn-about-firewall-requirements-action": {
"defaultMessage": "瞭解防火牆要求",
"description": "Link to support article for firewall requirements"
Expand Down
3 changes: 3 additions & 0 deletions src/components/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import React, { forwardRef } from "react";
import { useProject } from "../hooks/project-hooks";
import { getMakeCodeLang } from "../settings";
import { useSettings } from "../store";
import { getEditorVersionOverride } from "../editor-version";

const controllerId = "MicrobitMachineLearningTool";

Expand All @@ -27,10 +28,12 @@ const Editor = forwardRef<MakeCodeFrameDriver, EditorProps>(function Editor(
return (
<MakeCodeFrame
ref={ref}
queryParams={{ hidelanguage: "1" }}
controllerId={controllerId}
controller={2}
lang={getMakeCodeLang(languageId)}
loading="eager"
version={getEditorVersionOverride()}
{...editorCallbacks}
{...props}
/>
Expand Down
Loading