Fix googlemaps not displaying gmscore requesting location permission … #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the first time
mar-v-in
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Google Maps invokes the location settings implemented via #2216. We can use those settings to also request permissions for microG if necessary, allowing for cleaner integration as calling the location settings is expected by the caller.
| } else { | ||
| completable.complete(false) | ||
| } | ||
| val permissionRequest = activePermissionRequestLock.withLock {CompletableDeferred<Boolean>()} |
There was a problem hiding this comment.
This can cause the activity to be invoked multiple times, we only want to start it once
| private val requestManager by lazy { LocationRequestManager(context, lifecycle, postProcessor, database) { onRequestManagerUpdated() } } | ||
| private val requestManager by lazy { LocationRequestManager(context, lifecycle, postProcessor, database) { | ||
| lifecycleScope.launchWhenStarted { | ||
| ensurePermissions() |
There was a problem hiding this comment.
This doesn't seem to be the right spot for this.
There was a problem hiding this comment.
Do you have any good suggestions, since I haven't found a more suitable place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem that the location permission of Google Maps does not pop up when entering gmscore for the first time. Fixed the issue where gmscore’s location permission request would only run once