Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another performance PR, this is probably the most beneficial one among all, avoiding extra stream overhead, zero-sized list, O(n²). It could probably get a whole order of a magnitude speed up if #6113 would be implemented (we can then create a same-sized array and fill it in a single iteration, then create tags without any unnecessary re-sorting).
I'm having too many benchmark reports in my files to be sure i'm picking the right one, so i'll rerun them soon. Just to get a glimpse, this is what i'm looking at and what could be not the latest version (the last ones would be pretty rare in real applications; they would also usually filter around 62 tags out of 64, thus the drop compared to 8/32 combination). Set.of(), available only for java 9+, would be even more performant if supplied by end users.