Skip to content

Need to update predeploy.ps1 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lormadus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Need to update predeploy.ps1 #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployment/hooks/predeploy.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ try {
$acrBuildArgs = @("--build-arg", "ENTRA_SPA_CLIENT_ID=$clientId", "--build-arg", "ENTRA_TENANT_ID=$tenantId")
if ($backendClientId) { $acrBuildArgs += @("--build-arg", "ENTRA_BACKEND_CLIENT_ID=$backendClientId") }
if ($appInsightsConnStrEscaped) { $acrBuildArgs += @("--build-arg", "APPLICATIONINSIGHTS_FRONTEND_CONNECTION_STRING=$appInsightsConnStrEscaped") }
$buildOutput = az acr build --registry $acrName --image "web:$imageTag" `
$buildOutput = az acr build --registry $acrName --resource-group $env:AZURE_RESOURCE_GROUP_NAME --image "web:$imageTag" `

Copilot AI Apr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

az acr build is now using $env:AZURE_RESOURCE_GROUP_NAME directly, but this script already resolves the resource group via Get-AzdValue into $resourceGroup (with a fallback when env vars aren’t present). Using the env var here can make ACR cloud builds fail when the hook is run without injected env vars even though azd env get-value works. Use $resourceGroup (and fail fast if it’s empty) for consistency with the rest of the script.

Suggested change
$buildOutput = az acr build --registry $acrName --resource-group $env:AZURE_RESOURCE_GROUP_NAME --image "web:$imageTag" `
if ([string]::IsNullOrWhiteSpace($resourceGroup)) { throw "AZURE_RESOURCE_GROUP_NAME is required for ACR cloud build" }
$buildOutput = az acr build --registry $acrName --resource-group $resourceGroup --image "web:$imageTag" `

Copilot uses AI. Check for mistakes.
@acrBuildArgs `
--file deployment/docker/frontend.Dockerfile . `
--no-logs --only-show-errors 2>&1
Expand Down
Loading