An error during OAuth could result in the OnSigninFailure not getting called - #915
Merged
Merged
Conversation
tracyboehrer
requested review from
a team,
ceciliaavila and
sw-joelmut
as code owners
July 15, 2026 17:45
tracyboehrer
enabled auto-merge
July 15, 2026 17:45
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in the Builder-layer user sign-in orchestration where an OAuth exception during an Invoke activity could cause the sign-in flow to exit early, preventing the configured sign-in failure handler (and fallback “SignIn Failed” message) from running.
Changes:
- Removed an early
return falseafter emitting anInvokeResponseso the sign-in failure path can continue to_userSignInFailureHandler/ fallback failure messaging.
MattB-msft
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #858