Add soft delete to workspace storage account #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4385 Add soft delete configuration to Workspace storage accounts. * Add `blob_properties` block with `delete_retention_policy` and `container_delete_retention_policy` settings to `azurerm_storage_account` resource in `templates/workspaces/base/terraform/storage.tf`. * Add `file_properties` block with `delete_retention_policy` settings to `azurerm_storage_account` resource in `templates/workspaces/base/terraform/storage.tf`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4385?shareId=XXXX-XXXX-XXXX-XXXX).
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 6ad9900. ♻️ This comment has been updated with latest results. |
jonnyry
reviewed
Feb 21, 2025
@jonnyry done. |
jonnyry
approved these changes
Feb 21, 2025
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/14213811131 (with refid (in response to this comment from @marrobi) |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 6ad9900) (in response to this comment from @tamirkamara) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4385
Add soft delete configuration to Workspace storage accounts.
blob_propertiesblock withdelete_retention_policyandcontainer_delete_retention_policysettings toazurerm_storage_accountresource intemplates/workspaces/base/terraform/storage.tf.file_propertiesblock withdelete_retention_policysettings toazurerm_storage_accountresource intemplates/workspaces/base/terraform/storage.tf.For more details, open the Copilot Workspace session.