Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Document Intelligence Module #2834

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Azure Document Intelligence Module #2834

wants to merge 16 commits into from

Conversation

Groenbech96
Copy link
Contributor

@Groenbech96 Groenbech96 commented Jan 23, 2025 •
edited by github-actions bot
Loading

Azure Document Intelligence support

  • OnPrem for now. Uptake available for 1p apps.
  • Move capabilities to Capabilities Impl Codeunit.
  • Introduce Azure AI Service Enum.

image

image

AB#563692

  • Fix the privacy notice tok

@Groenbech96 Groenbech96 requested a review from a team as a code owner January 23, 2025 13:12
@Groenbech96 Groenbech96 changed the title Add ADI Azure Document Intelligence Module Jan 23, 2025
NKarolak
NKarolak suggested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@NKarolak NKarolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latin is nice, but maybe not popular enough ;-)

src/System Application/App/AI/src/DocumentIntelligence/ADIModelType.Enum.al Outdated Show resolved Hide resolved
src/System Application/App/AI/src/DocumentIntelligence/AzureDIImpl.Codeunit.al Outdated Show resolved Hide resolved
src/System Application/App/AI/src/DocumentIntelligence/AzureDIImpl.Codeunit.al Outdated Show resolved Hide resolved
darjoo
darjoo reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@darjoo darjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes for introducing ADI, minor comments.

src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDI.Codeunit.al Outdated Show resolved Hide resolved
src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDIImpl.Codeunit.al Show resolved Hide resolved
src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDIImpl.Codeunit.al Show resolved Hide resolved
src/System Application/App/AI/src/Azure AI Document Intelligence/ADIModelType.Enum.al Outdated Show resolved Hide resolved
src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDI.Codeunit.al Outdated Show resolved Hide resolved
Magnus Hartvig Grønbech added 2 commits February 5, 2025 15:01
@github-actions github-actions bot added this to the Version 26.0 milestone Feb 6, 2025
Groenbech96
Groenbech96 commented Feb 6, 2025
View reviewed changes
Copy link
Contributor Author

@Groenbech96 Groenbech96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

src/System Application/App/AI/src/Azure OpenAI/AzureOpenAIImpl.Codeunit.al Outdated Show resolved Hide resolved
src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDIImpl.Codeunit.al Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jose-agg Jose-agg Jose-agg left review comments

@encimita encimita encimita left review comments

@msft-sam msft-sam msft-sam left review comments

@NKarolak NKarolak NKarolak requested changes

@darjoo darjoo darjoo approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
AL: System Application
Projects
None yet
Milestone
Version 26.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Groenbech96 @darjoo @NKarolak @Jose-agg @encimita @msft-sam