Skip to content

PR #10: Sample topics + templates + test sets - #33

Merged
saengland merged 4 commits into
main2from
review/10-samples
May 7, 2026
Merged

PR #10: Sample topics + templates + test sets#33
saengland merged 4 commits into
main2from
review/10-samples

Conversation

@saengland

Copy link
Copy Markdown
Collaborator

Note: This PR replaces the original #20, which was prematurely merged earlier today during a tooling incident and rolled back.
The branch (review/10-samples) and code are unchanged - re-opening here so it gets the proper review + approval flow before merging.

Original PR body preserved below.


Adds sample content under solutions/ess-agent-kit/src/examples/ess-samples/:

  • ESSEvaluationSamples/ ΓÇö starter and templated evaluation test sets (CSV)
  • Facilities/ ΓÇö facilities scenarios (5 sample topics)
  • ServiceNow/ ΓÇö HRSD, ITSM, Catalog scenarios (8 sample topics)
  • Workday/ ΓÇö employee and manager scenarios (16 sample topics)

91 files total (YAML topic definitions, JSON workflow definitions, XML template config, CSV test sets). Sourced from Copilot Studio Samples repo ΓÇö verify no customer-specific data slipped in.

Tracker: #10

Adds sample content under solutions/ess-agent-kit/src/examples/ess-samples/:
- ESSEvaluationSamples/ - starter and templated evaluation test sets (CSV)
- Facilities/ - facilities scenarios (5 sample topics)
- ServiceNow/ - HRSD, ITSM, Catalog scenarios (8 sample topics)
- Workday/ - employee and manager scenarios (16 sample topics)

91 files total (YAML topic definitions, JSON workflow definitions, XML template config, CSV test sets). Sourced from Copilot Studio Samples repo - verify no customer-specific data slipped in.

Reviewer: @CavillMason
Tracker: #10
rename solutions/ess-agent-kit -> solutions/ess-maker-skills
Adds an 'ESS Maker Kit Snapshot Notice' section to the existing upstream README under src/examples/ess-samples/. Documents source URL, snapshot date (2026-04-29), refresh policy (hand-PR; sync_samples.py auto-fetcher was removed in slice PR #3), and the explicit 'do not edit these files - put customer scenarios under workspace/agents/{slug}/topics/ instead' rule.

Mirrors the slice PR #9 reference-docs README. Addresses the 'feels wasteful to be cloning those' concern raised by @johnguy0; the duplication is the explicit tradeoff that gives the kit domain-correct first-turn output, and the snapshot stamp makes the staleness contract explicit.

Also notes that the ServiceNow/ folder is kit-team-added (not in upstream microsoft/CopilotStudioSamples) for transparency.
@saengland
saengland merged commit b71148d into main2 May 7, 2026
4 checks passed
@saengland
saengland deleted the review/10-samples branch May 7, 2026 17:52
saengland added a commit that referenced this pull request May 7, 2026
… without reviewer approval; restoring branch for proper review
@saengland
saengland restored the review/10-samples branch May 7, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant