Adds Requirement Type All and Any to FeatureFlags - #221
Merged
Conversation
Ross Grambo (rossgrambo)
requested review from
Avani Gupta (avanigupta) and
Jimmy Campbell (jimmyca15)
March 29, 2023 20:57
Ross Grambo (rossgrambo)
force-pushed
the
rossgrambo/requirement-type-all
branch
from
March 31, 2023 21:28
23b7098 to
13ec4ea
Compare
Ross Grambo (rossgrambo)
requested review from
Avani Gupta (avanigupta) and
Jimmy Campbell (jimmyca15)
March 31, 2023 21:40
… evaluate a true filter, more comments
Contributor
Author
|
I addressed the comments, but I also re-wrote my changes to the FeatureManager to have less edge-cases. Both Any and And now have the same default: false I also combined some of the inner logic so the Contextual and non-Contextual filters have less duplicated code. |
…, pulled the RequirementType.All and IgnoreMissingFeatureFilters restriction further up so it happens anytime the feature is evaluated.
Ross Grambo (rossgrambo)
force-pushed
the
rossgrambo/requirement-type-all
branch
from
April 4, 2023 21:10
392bfbe to
2511c26
Compare
…me checks to be more readable
Ross Grambo (rossgrambo)
force-pushed
the
rossgrambo/requirement-type-all
branch
from
April 5, 2023 02:04
f407d54 to
850b1eb
Compare
Ross Grambo (rossgrambo)
requested review from
Avani Gupta (avanigupta) and
Jimmy Campbell (jimmyca15)
April 5, 2023 02:06
Ross Grambo (rossgrambo)
force-pushed
the
rossgrambo/requirement-type-all
branch
from
April 5, 2023 22:37
7fb0abd to
51377dc
Compare
Jimmy Campbell (jimmyca15)
approved these changes
Apr 5, 2023
Avani Gupta (avanigupta)
approved these changes
Apr 5, 2023
This was referenced Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to issue #28.
And as a rewrite of PR #192.
Add Requirement Type All and Any to FeatureFlags
Filters on Feature Flags have always used "Any" logic. Our execution goes through each filter and when a single one returns "true", we end execution and return true. This PR adds "All" logic. For "All", the execution instead goes through each filter and when a single one returns "false", we end execution, returning false. Otherwise we return true.
In short- this PR:
Example
Evaluation