Skip to content

Conversation

carsonRadtke
Copy link
Member

We used have tests contained in a single executable. This was fine for testing, but it would be more convient to separate tests into indivudal modules so targeted changes could have targeted tests.

This change associates each test file with its own executable. We now have 14 tests for GSL each of which testing a different component.

Drive-by: Update the span tests to just check for C++14 and MSVC because that is easier than updating the MSVC version check each release.

@carsonRadtke carsonRadtke requested a review from Copilot August 21, 2025 16:12
@carsonRadtke carsonRadtke self-assigned this Aug 21, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the GSL test infrastructure by separating tests from a single monolithic executable into individual test executables for each component. This change improves development workflow by enabling targeted testing of specific components.

  • Splits the single gsl_tests executable into 14 individual test executables, one per test source file
  • Simplifies MSVC version checks in span tests to focus on C++14 compatibility instead of specific compiler versions
  • Maintains the same test coverage while improving modularity and development experience

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/CMakeLists.txt Refactors build system to create individual executables for each test source file using a foreach loop
tests/span_tests.cpp Simplifies MSVC version checks by removing specific version numbers and focusing on C++14 standard

@carsonRadtke carsonRadtke added Type: Infra Changes to build system, tests, or pipelines Status: In Progress Currently being worked on labels Aug 21, 2025
carsonRadtke and others added 3 commits October 1, 2025 10:05
We used have tests contained in a single executable. This was fine for
testing, but it would be more convient to separate tests into indivudal
modules so targeted changes could have targeted tests.

This change associates each test file with its own executable. We now
have 14 tests for GSL each of which testing a different component.
thanks copilot

Co-authored-by: Copilot <[email protected]>
@carsonRadtke carsonRadtke force-pushed the carsonradtke/individual-tests branch from dbcffab to 1bb885c Compare October 1, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: In Progress Currently being worked on Type: Infra Changes to build system, tests, or pipelines

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

1 participant